fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34115 ) Change subject: l1ctl: Fill ph_data_param fn field ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34115/comment/41f070cc_36dffcfc PS1, Line 7: Fill ph_data_param fn field Should have been noted in the commit message that the current LAPDm implementation makes no use of this field (it's only used for RACH) and the upper layers on top of LAPDm will get no access to the Fn value filled in here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3317296b2bda1088a2af81ba9b135714f8393afd Gerrit-Change-Number: 34115 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment