Attention is currently required from: fixeria, laforge, osmith. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email ) Change subject: subscriber-create-on-demand: rework configuration ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: this makes the code a lot nicer. File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/37779/comment/679d6922_90e79794?usp… : PS1, Line 300: vty_out(vty, " no subscriber-create-on-demand%s", VTY_NEWLINE); my perception is we have not much consistency in that regard. Some values we deem important to print defaults for, others we omit. (Also for some we use 'foo delete' and for others 'no foo'... etc) Contrary to my favorite, it seems to me that later osmocom does tend towards omitting defaults, while earlier osmocom used to write defaults more. When I see new software I find it very useful to have a config file with all the options listed explicitly; often all the defaults are listed, but commented out, that's nice. That would be my personal favorite, but that would also be a totally new first for osmocom. It is less code complexity to just write everything. Is create-on-demand a fringe feature that needs no visibility? Depends on the corporate vs communal POV... I'm afraid this is an endless discussion topic, I'd just let fixeria make a choice and be fine with that. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9 Gerrit-Change-Number: 37779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 01:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>