Attention is currently required from: iedemam. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28061 )

Change subject: fix fallout from: 'stats: new trackers for lchan life duration' ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28061/comment/002ab155_9a0c1a72 PS1, Line 531: osmo_time_cc_cleanup(&lchan->active_cc);

hm, this fix works, yet below, the active_cc is actually not cleared out but kept as-is. […]

it is like this: when a BTS terminates the connection, it terminates and deallocates the timeslot and lchan FSM instances. So the important part is that the timer is deactivated in lchan_fsm_cleanup(), before deallocation. calling osmo_time_cc_cleanup() stops the timer if running.

it's anyway also a good thing to make sure the timer is stopped in lchan_reset(), which is called in the lchan life cycle whenever the lchan "stops" or "starts over".