Attention is currently required from: iedemam.

View Change

1 comment:

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #1, Line 531: osmo_time_cc_cleanup(&lchan->active_cc);

    hm, this fix works, yet below, the active_cc is actually not cleared out but kept as-is. […]

    it is like this: when a BTS terminates the connection, it terminates and deallocates the timeslot and lchan FSM instances. So the important part is that the timer is deactivated in lchan_fsm_cleanup(), before deallocation. calling osmo_time_cc_cleanup() stops the timer if running.

    it's anyway also a good thing to make sure the timer is stopped in lchan_reset(), which is called in the lchan life cycle whenever the lchan "stops" or "starts over".

To view, visit change 28061. To unsubscribe, or for help writing mail filters, visit settings.