Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 2: (3 comments) File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/d994406f_2ef00411 PS2, Line 12: no shutdown 'no shutdown' again? I understand the idea that the user may want to switch between APNs, or even activate several at the same time (if this is possible at all), but something like 'active' or 'enabled' would be more intuitive, IMO. File src/host/layer23/include/osmocom/bb/common/apn.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/03f80523_b141dbf1 PS2, Line 62: //struct in6_addr v6_lladdr; TODO? File src/host/layer23/include/osmocom/bb/common/ms.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/5129f065_06866b2c PS2, Line 94: gprs_settings Ideally, all settings should be in struct gsm_settings. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:44:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment