Attention is currently required from: Hoernchen.

dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40467?usp=email )

Change subject: smdpp: validate eid ......................................................................

Patch Set 5: Code-Review+2 Verified+1

(3 comments)

Patchset:

PS5: This looks ok to me. I have tried it out and it works fine. I would suggest to put the verification code into a separate module.

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/40467/comment/ca988042_3cd6771e?usp=ema... : PS5, Line 7: smdpp: validate eid This is quite a complex patch. Maybe it would be helpful to write one or two lines on what it does and why it is needed? (I know this but maybe others who read the commit log have no clue.)

File osmo-smdpp.py:

https://gerrit.osmocom.org/c/pysim/+/40467/comment/356bd6af_df41c0be?usp=ema... : PS5, Line 133: print(f"Found GSMA permittedEins extension: {ext.oid}") Interesting, never saw this print(f"... thing before.