Attention is currently required from: neels, laforge, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 10: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/c0eb2ff2_1c1f9fff PS7, Line 11: This violates the spec No. The spec which this is about. I haven't found it again. Sorry. File include/osmocom/hlr/hlr_ps.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/a3d0bea4_252a9fac PS9, Line 23: #pragma once Done https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/839c24b5_ff44e25a PS9, Line 32: struct { Done File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/1f866ebb_ad3d3a27 PS9, Line 252: info->apn_enc = (uint8_t *) talloc_strdup(g_hlr, apn_name); Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 11:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment