Attention is currently required from: neels, laforge, daniel.

View Change

4 comments:

• Commit Message:

  • Patch Set #7, Line 11: This violates the spec

    spec reference please? […]

    No. The spec which this is about. I haven't found it again. Sorry.

• File include/osmocom/hlr/hlr_ps.h:

  • Patch Set #9, Line 23: #pragma once

    This file is never included anywhere. […]

    Done

  • Patch Set #9, Line 32: struct {

    Now sure if an anonymous struct as top level in a header file makes sense? […]

    Done

• File src/hlr_vty.c:

  • Patch Set #9, Line 252: info->apn_enc = (uint8_t *) talloc_strdup(g_hlr, apn_name);

    This is actually wrong since you simply copy the profile info over in the GSUP message. […]

    Done

To view, visit change 32512. To unsubscribe, or for help writing mail filters, visit settings.