laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28955 ) Change subject: tests/rlcmac: use ARRAY_SIZE macro ...................................................................... tests/rlcmac: use ARRAY_SIZE macro Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index f2b0447..9ba7831 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -55,10 +55,8 @@ "40883c1493120000000012002b2b2b2b2b2b2b2b2b2b2b", // Pkt Paging Request (OS#4838) }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - cout << " DOWNLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); @@ -109,11 +107,8 @@ "4017e5b2cd5a2eca68655e44aec84880139300412b2b2b", }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - - cout << " UPLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 Gerrit-Change-Number: 28955 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged