[L] Change in libosmo-netif[master]: Add osmo_io support to osmo_stream_cli and osmo_stream_srv - gerrit-log

9 Jun 2023

Attention is currently required from: arehbein, laforge, daniel.

pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )

Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
......................................................................

Patch Set 10:

(4 comments)

Patchset:

PS10: 
So I think the only relevant thing to wrap here is whether we want to have the 2 callback
function passed during _create() time, or have separate APIs to set it and keep the
_create function more generic.

Right now we have the callback passed in _srv_create() but we have them in separate APIs
in _cli_create(), which looks even more confusing.

I'm favour of setting the callback functions using separate APIs in order to avoid
more potential API break in the future, letting others provide feedback here.

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/049877d5_79884ca8 
PS7, Line 620: 		if (msg && res <= 0) {
...
  This shouldn't happen since osmo_io only writes to
the fd if it's writable. Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/ff6cb9ec_b3f9c398 
PS7, Line 1046: 			cli->iofd = osmo_iofd_setup(cli, -1, cli->name,
OSMO_IO_FD_MODE_READ_WRITE, &osmo_stream_cli_ioops, cli);
...
  The relevant fd is in osmo_iofd_register(). […]
Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/e7450fc0_7ce20e7e 
PS7, Line 1540: 			osmo_stream_srv_destroy(conn);
...
  Not in a void function :-) […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 10
Gerrit-Owner: arehbein &lt;arehbein(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: arehbein &lt;arehbein(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 09 Jun 2023 14:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-MessageType: comment