Attention is currently required from: arehbein, laforge, daniel.

View Change

4 comments:

• Patchset:

  • Patch Set #10:

    So I think the only relevant thing to wrap here is whether we want to have the 2 callback function passed during _create() time, or have separate APIs to set it and keep the _create function more generic.

    Right now we have the callback passed in _srv_create() but we have them in separate APIs in _cli_create(), which looks even more confusing.

    I'm favour of setting the callback functions using separate APIs in order to avoid more potential API break in the future, letting others provide feedback here.

• File src/stream.c:

  • Patch Set #7, Line 620: if (msg && res <= 0) {

    This shouldn't happen since osmo_io only writes to the fd if it's writable.

    Done

  • Patch Set #7, Line 1046: cli->iofd = osmo_iofd_setup(cli, -1, cli->name, OSMO_IO_FD_MODE_READ_WRITE, &osmo_stream_cli_ioops, cli);

    The relevant fd is in osmo_iofd_register(). […]

    Done

  • Patch Set #7, Line 1540: osmo_stream_srv_destroy(conn);

    Not in a void function :-) […]

    Done

To view, visit change 33193. To unsubscribe, or for help writing mail filters, visit settings.