Attention is currently required from: daniel, laforge, neels.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email )

Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ......................................................................

Patch Set 5:

(1 comment)

File src/libosmo-mgcp/mgcp_msg.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/84d18ed5_752b53bb?usp=... : PS4, Line 257: LOGP(DLMGCP, LOGL_NOTICE, "wrong MGCP option format: '%s'\n", line);

An error like this should be catched up by caller layers holding conn information, and then print co […]

See for instance in mgcp_client.c you want to actually undup the code, which wouldn't be possible if you still passed some client/mgw specific struct here:

src/libosmo-mgcp-client/mgcp_client.c 281:/* TODO undup against mgcp_protocol.c:mgcp_check_param() */