Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 )
Change subject: Add osmo_io with initial poll backend ......................................................................
Patch Set 1:
(24 comments)
File include/osmocom/core/osmo_io.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a06005a2_b630304e PS1, Line 28: void (*read_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a6882882_97172bed PS1, Line 28: void (*read_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/34dae675_42dee70d PS1, Line 30: void (*write_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/4daaa2a1_cf98da01 PS1, Line 30: void (*write_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/e73886e1_eeeaf2c4 PS1, Line 33: void (*sendmsg_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/90bd2fce_ca06ee12 PS1, Line 33: void (*sendmsg_cb)(struct osmo_io_fd *, int res, struct msgb *); function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/e4f803f5_59a8b316 PS1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *); function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/dfd5ab6a_2d4e0773 PS1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *); function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/cc035462_005f9fb0 PS1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *); function definition argument 'struct osmo_sockaddr *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/d82689fd_e87daffe PS1, Line 38: int (*segmentation_cb)(struct msgb *, int data_len); function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/36042dd0_0772c714 PS1, Line 41: void osmo_io_init(); Bad function definition - void osmo_io_init() should probably be void osmo_io_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a936804e_ce32a8bc PS1, Line 52: const struct osmo_sockaddr *dest); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/d3eef3f3_083169f7 PS1, Line 52: const struct osmo_sockaddr *dest); please, no spaces at the start of a line
File src/osmo_io.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/99590406_b38a3166 PS1, Line 53: void osmo_iofd_init() Bad function definition - void osmo_iofd_init() should probably be void osmo_iofd_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a6271d9a_bb9bafff PS1, Line 226: memcpy(msgb_data(msg_pending), msgb_data(msg)+ len, pending_len); need consistent spacing around '+' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/bd552a2b_5ca6e479 PS1, Line 237: void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/faf5728a_cd6bc557 PS1, Line 278: LOGP(DLIO, LOGL_ERROR, "iofd(%s) enqueueing message failed (%i). Rejecting msgb\n", iofd->name, rc); Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/0d760490_668e3395 PS1, Line 314: LOGP(DLIO, LOGL_ERROR, "iofd(%s) enqueueing message failed (%i). Rejecting msgb\n", iofd->name, rc); Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/ea9a86bb_c1b53d3e PS1, Line 401: void osmo_iofd_close(struct osmo_io_fd* iofd) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/68e2e3e3_910b42c8 PS1, Line 440: } adding a line without newline at end of file
File src/osmo_io_internal.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/00a26127_b6684372 PS1, Line 53: /*! size of msgb to allocte (excluding headroom) */ 'allocte' may be misspelled - perhaps 'allocate'?
File src/osmo_io_poll.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/ff326b3c_14e933ee PS1, Line 86: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f5e5ec12_2b561022 PS1, Line 146: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606): https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/bcdbf899_b439231c PS1, Line 219: }; adding a line without newline at end of file
-
Jenkins Builder