24 comments:
File include/osmocom/core/osmo_io.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 28: void (*read_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 28: void (*read_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 30: void (*write_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 30: void (*write_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 33: void (*sendmsg_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 33: void (*sendmsg_cb)(struct osmo_io_fd *, int res, struct msgb *);
function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *);
function definition argument 'struct osmo_io_fd *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *);
function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 35: void (*recvmsg_cb)(struct osmo_io_fd *, int res, struct msgb *, struct osmo_sockaddr *);
function definition argument 'struct osmo_sockaddr *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 38: int (*segmentation_cb)(struct msgb *, int data_len);
function definition argument 'struct msgb *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 41: void osmo_io_init();
Bad function definition - void osmo_io_init() should probably be void osmo_io_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 52: const struct osmo_sockaddr *dest);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 52: const struct osmo_sockaddr *dest);
please, no spaces at the start of a line
File src/osmo_io.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 53: void osmo_iofd_init()
Bad function definition - void osmo_iofd_init() should probably be void osmo_iofd_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 226: memcpy(msgb_data(msg_pending), msgb_data(msg)+ len, pending_len);
need consistent spacing around '+' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 237: void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 278: LOGP(DLIO, LOGL_ERROR, "iofd(%s) enqueueing message failed (%i). Rejecting msgb\n", iofd->name, rc);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 314: LOGP(DLIO, LOGL_ERROR, "iofd(%s) enqueueing message failed (%i). Rejecting msgb\n", iofd->name, rc);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 401: void osmo_iofd_close(struct osmo_io_fd* iofd)
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
adding a line without newline at end of file
File src/osmo_io_internal.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
Patch Set #1, Line 53: /*! size of msgb to allocte (excluding headroom) */
'allocte' may be misspelled - perhaps 'allocate'?
File src/osmo_io_poll.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2606):
adding a line without newline at end of file
To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.