Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 ) Change subject: ill-fated ipcv2 for mstrx ...................................................................... Patch Set 2: (237 comments) File Transceiver52M/device/ipc2/IPCDevice.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5eb0c714_10ee29c1 PS2, Line 40: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6651161_e98b5749 PS2, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d1c36682_941a2da2 PS2, Line 41: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0309d99f_d325d12e PS2, Line 41: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/181f24ff_3c81b73c PS2, Line 41: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6390f5a_84f02b55 PS2, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/74f0c2d7_3b8f6326 PS2, Line 48: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e28c3717_0e5bc19f PS2, Line 48: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/14970ee1_c6aa8d34 PS2, Line 57: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3b16b05_6d030687 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ebba5fff_4b269633 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a91daa5_9433bcd3 PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0ac42c66_8d16cffb PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/389dc8c4_9fd06a79 PS2, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f3b4d1_f8c4a67c PS2, Line 67: virtual bool start() override; Bad function definition - virtual bool start() should probably be virtual bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01cdc5de_098ffd82 PS2, Line 70: virtual bool stop() override; Bad function definition - virtual bool stop() should probably be virtual bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b0e01f01_2c6b7faa PS2, Line 73: enum TxWindowType getWindowType() override Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d448e734_fc23cd20 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aaa757a1_87ad6be3 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b512702_3e193375 PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/280e3c99_4ec715d6 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/313b4380_8034db45 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d890133c_55ca5193 PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e1e8e0b_7910299f PS2, Line 98: TIMESTAMP timestamp = 0xffffffff) override; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/05623a62_f45b2370 PS2, Line 116: virtual double fullScaleInputValue() override Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e6fe73b2_79acfa36 PS2, Line 122: virtual double fullScaleOutputValue() override Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/563a6b6b_eadaa9a7 PS2, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f3fe317_ffcfd8d4 PS2, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1900fd3a_275c0587 PS2, Line 166: virtual bool requiresRadioAlign() override; Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f8a6e9_f0f8af19 PS2, Line 180: virtual inline double getSampleRate() override Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void) File Transceiver52M/device/ipc2/ipcif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7156ba40_b312c199 PS2, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fee2edef_3cac70b9 PS2, Line 35: using sample_t = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c9d33b7_95085a2e PS2, Line 37: std::atomic<bool> ms_connected; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59a78da7_77505797 PS2, Line 37: std::atomic<bool> ms_connected; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6904fbb_07150c9b PS2, Line 37: std::atomic<bool> ms_connected; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b3974ff_e5789b98 PS2, Line 39: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89a3fffe_65643b9a PS2, Line 40: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/beb8ed7b_acf6fac7 PS2, Line 41: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38fb8844_2dcfabdf PS2, Line 41: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7cfbbf69_ec0c6aee PS2, Line 41: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fbf1e6ae_43c98e90 PS2, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8efd569_60c5b775 PS2, Line 42: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/593e0c8f_1844ba23 PS2, Line 42: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/194837c0_8000ed00 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce257af0_156038c6 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9a845225_9f4ac600 PS2, Line 43: std::atomic<size_t> len_written_sps; // -> labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1ba05bc2_7435f43b PS2, Line 47: shm::sema r; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/22053d07_5810e706 PS2, Line 48: shm::sema w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/44b3db41_65b7ce63 PS2, Line 49: std::atomic<uint64_t> ts; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f3ed677_2174adcf PS2, Line 49: std::atomic<uint64_t> ts; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c048fe0_42ba4889 PS2, Line 49: std::atomic<uint64_t> ts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36599d53_564249b6 PS2, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/bae00da5_75f5e75b PS2, Line 50: std::atomic<uint64_t> ts_req; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/28ec1a63_da15a818 PS2, Line 50: std::atomic<uint64_t> ts_req; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9086905a_01283fd8 PS2, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0d0cff4f_9af47237 PS2, Line 51: std::atomic<size_t> len_written_sps; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ed36f073_52466fa0 PS2, Line 51: std::atomic<size_t> len_written_sps; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/184a26e8_b330aaf8 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5ce200e0_2d92dc62 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abfdc864_72902c5f PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8cad5dfd_28ca9436 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88498a7c_28c05de3 PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c0d245d_e49e9a50 PS2, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2912444_75bbc1ed PS2, Line 60: using stype = typename std::make_signed<A>::type; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5aab985a_e2c132df PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45d777bb_3cba3886 PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd47cd47_57d9fbd5 PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2842c9d1_7d08a76d PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0fce91ef_17a02c37 PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59d7ca3a_ba0a7c36 PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0d7963b_00d5eb89 PS2, Line 91: std::mutex ul_q_m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/646c55cd_bcf6b799 PS2, Line 98: void cur_buf_done() Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8814733c_6624eced PS2, Line 98: void cur_buf_done() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2123386_6029ea20 PS2, Line 103: bool is_empty() Bad function definition - bool is_empty() should probably be bool is_empty(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f7d4b763_7d26bf38 PS2, Line 103: bool is_empty() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4d4b6121_04cb1d91 PS2, Line 107: void reset() Bad function definition - void reset() should probably be void reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/685009e0_61ee5fde PS2, Line 107: void reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ac466315_88346419 PS2, Line 109: for (auto &i : foo) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ca3ae6d_61f2063f PS2, Line 113: ulentry &find_free_at_end() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9708e2ed_08ffb55b PS2, Line 123: void push_back(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afdb222e_0b15a608 PS2, Line 123: void push_back(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01e5f853_6b5c4ccd PS2, Line 130: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08b6858e_3879250f PS2, Line 131: void add(ulentry &e) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fe53ecb5_f45ca93f PS2, Line 131: void add(ulentry &e) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1525b4c3_a519002e PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87a23cd3_2fcd6dfc PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e03c7c7a_05ce8b37 PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4ae76d3_453be567 PS2, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6dc104f_2162c7b2 PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd734b0b_27cb756e PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89adcdfc_abcc80f4 PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b209e52_8e8a9dc8 PS2, Line 149: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2289784_ae5c19cf PS2, Line 159: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e8b3733_71999982 PS2, Line 171: memset((void*)buf, 0, samp2byte(req_len_in_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dc8c758b_4dd5b0e2 PS2, Line 176: memset((void*)buf, 0, samp2byte(to_pad_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee5f6fb2_3c180621 PS2, Line 203: shm::shm<shm_if> m; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8b5bca22_4a30b325 PS2, Line 203: shm::shm<shm_if> m; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca950797_63eb1a09 PS2, Line 203: shm::shm<shm_if> m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d7347d_77bdf7d4 PS2, Line 206: ulburstprovider<10> p; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f91b6d2e_3a060b86 PS2, Line 206: ulburstprovider<10> p; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad1573f6_8e72f597 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0566160d_cb81fae6 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2ca303f5_b37008d8 PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d0b9388_85157e47 PS2, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29a83a99_ea999a57 PS2, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/07f8d3d6_dfb53bd9 PS2, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/18d29d35_593629fb PS2, Line 249: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ec0996e8_0b226007 PS2, Line 263: shm::mtx_log::print_guard() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/249099cf_bcde4534 PS2, Line 270: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dd76bb9_367bca4f PS2, Line 275: bool create() Bad function definition - bool create() should probably be bool create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9b01aef9_c2337ba9 PS2, Line 275: bool create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590aac2a_fde9acaf PS2, Line 281: bool connect() Bad function definition - bool connect() should probably be bool connect(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d2f702a_09524393 PS2, Line 281: bool connect() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb6739b3_3f1194b1 PS2, Line 289: bool good() Bad function definition - bool good() should probably be bool good(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2bf91492_7a597009 PS2, Line 289: bool good() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8ffd5db3_a7616ad7 PS2, Line 293: bool is_connected() Bad function definition - bool is_connected() should probably be bool is_connected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f9458b36_7c5c153e PS2, Line 293: bool is_connected() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c7c4fb6_17bad2c7 PS2, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ca99336_f48faa03 PS2, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f86345d9_af441b42 PS2, Line 308: memset((void*)outbuf, 0, samp2byte(howmany_sps)); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/97d9771c_6ae0586d PS2, Line 309: // return; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fa723613_f217bc71 PS2, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59c2feed_341009cd PS2, Line 316: auto &dl = ptr->dl; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4e49cd64_45664729 PS2, Line 325: shm::sema_wait_guard g(dl.w, dl.r); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad0f71a5_91013754 PS2, Line 331: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76bf94c7_7f935e9a PS2, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54ad6f8f_706b94a4 PS2, Line 338: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab1a9da7_5dff33dd PS2, Line 351: shm::mtx_log::print_guard() << std::endl labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/771e2923_63e2f334 PS2, Line 356: void drive_tx() Bad function definition - void drive_tx() should probably be void drive_tx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8d72181_ed656a07 PS2, Line 356: void drive_tx() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/318ad639_78ab26ac PS2, Line 358: auto &ul = ptr->ul; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/15e6dffb_ef0d3805 PS2, Line 384: void signal_read_start() Bad function definition - void signal_read_start() should probably be void signal_read_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/877dc66e_62b6b41d PS2, Line 384: void signal_read_start() open brace '{' following function definitions go on the next line File Transceiver52M/device/ipc2/shmif.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eb644607_9579c6f5 PS2, Line 46: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1693b05c_4bb74683 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b5bbfa5_1c8670d1 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aebeff6b_0459d5f1 PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/77c55d6f_dfef99da PS2, Line 50: std::cerr << str(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12cceaea_d6c1d40b PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0c928010_3bbd8cda PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c882d4b_4d36cebd PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0c6ca60_6268763e PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd0a84ff_367f7573 PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &)) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4ced4462_4170fd83 PS2, Line 73: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9afff3ef_55d2d279 PS2, Line 89: void lock() Bad function definition - void lock() should probably be void lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e3520517_7b7ea85b PS2, Line 89: void lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fb636e5e_faa6fd87 PS2, Line 94: bool try_lock() Bad function definition - bool try_lock() should probably be bool try_lock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef6b7112_fae2cba6 PS2, Line 94: bool try_lock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/90f7345f_c1af9d58 PS2, Line 99: void unlock() Bad function definition - void unlock() should probably be void unlock(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abff3ac7_ef507452 PS2, Line 99: void unlock() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/846764f3_24c01d36 PS2, Line 104: pthread_mutex_t *p() Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab804f25_91c09e89 PS2, Line 104: pthread_mutex_t *p() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72c380ce_cb1fd615 PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5dd0aec1_206f7b7e PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e9d9f048_bf8c7df3 PS2, Line 115: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/961dab4d_0a6761f7 PS2, Line 130: void wait(shmmutex *lock) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f61bada3_dff36445 PS2, Line 135: void signal() Bad function definition - void signal() should probably be void signal(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b48a1d13_a81d6db7 PS2, Line 135: void signal() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1877ddc9_18b81d69 PS2, Line 140: void signal_all() Bad function definition - void signal_all() should probably be void signal_all(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce5524ba_d16a1e47 PS2, Line 140: void signal_all() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/219eb1cc_89d7f6ae PS2, Line 145: shmcond &operator=(const shmcond &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eba2bf9a_5472fe0a PS2, Line 145: shmcond &operator=(const shmcond &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c83b8a93_a4cb8d6f PS2, Line 149: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12b2d928_fad62cdd PS2, Line 150: shmcond &s; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a30ea83_fe27cfdd PS2, Line 152: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d121565f_fcd777b4 PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/734fe99f_9ca7d80e PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/84dc4439_dac707f5 PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c34827e1_54bbad7a PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1780f1a9_9bbacec6 PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d3c669ff_60e5125d PS2, Line 169: shmmutex &m; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eeb28922_b3870366 PS2, Line 171: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d286ccd_38f19728 PS2, Line 173: explicit mutex_guard(shmmutex &m) : m(m) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23b6a7d0_5061701b PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c63ecb3_925b6fb8 PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e080a1cc_42dc1735 PS2, Line 186: std::atomic<int> value; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2da29632_3b624ac9 PS2, Line 186: std::atomic<int> value; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d1b2f2_e029394b PS2, Line 186: std::atomic<int> value; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29384ff2_faa033a4 PS2, Line 190: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/82c752e2_f164c4ca PS2, Line 198: void wait() Bad function definition - void wait() should probably be void wait(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5d21a9b8_b4be25b3 PS2, Line 198: void wait() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f77ff0c3_e09d6eb3 PS2, Line 202: void wait(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3660db1d_67bfbc58 PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/189d621f_de541083 PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee4a9e4f_edf77e3e PS2, Line 205: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4896d3c6_d4b455a8 PS2, Line 210: void wait_and_reset() Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b0d9ee6_a2cc2395 PS2, Line 210: void wait_and_reset() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/64dbc8eb_e1b03cf3 PS2, Line 214: void wait_and_reset(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39b3f525_24f813c2 PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/001c3da9_1e06e8cc PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01ec7353_26a6d2fb PS2, Line 217: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d46c281_0a713432 PS2, Line 223: void set() Bad function definition - void set() should probably be void set(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c328d9_ae226303 PS2, Line 223: void set() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a7c70f3_f161439e PS2, Line 227: void set(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e519b59_d35f0b65 PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f9baeb0_0826a66c PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl; __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2d07309f_8d3ee60c PS2, Line 230: mutex_guard g(m); function definition argument 'm' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8f33930e_101905f3 PS2, Line 234: void reset_unsafe() Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2064dcd_39ea23bf PS2, Line 234: void reset_unsafe() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3bb61d37_5e091d92 PS2, Line 238: bool check_unsafe(int v) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f39ccde_f6b5b66f PS2, Line 243: sema &operator=(const sema &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ada744ee_acaa6a36 PS2, Line 243: sema &operator=(const sema &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0388d9c3_795d2bf3 PS2, Line 247: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a94712c_d71ad545 PS2, Line 248: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96e6a50f_e4f4a28f PS2, Line 250: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f42e38_e2f5cee4 PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb60795f_d3e13d5c PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cdbf0ddd_f4cd39a0 PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dc97c45_1f6bfffe PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/214ab49f_17437e32 PS2, Line 265: sema &a; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/33074b0c_2436e030 PS2, Line 266: sema &b; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2f06355_23f043c5 PS2, Line 268: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b232afdb_b9b3cbca PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d41cbff9_5ae783ad PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dca3451f_4ba4aa85 PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afb11ee5_fac34b8e PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/daa77e76_8048a624 PS2, Line 282: template <typename IFT> class shm { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd41f343_ae2a9602 PS2, Line 282: template <typename IFT> class shm { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e396ae3_fb4e01bd PS2, Line 287: int ipc_shm_setup(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/450e2df9_836fb384 PS2, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/742af127_911a5c4f PS2, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3ada4cde_49942d79 PS2, Line 315: int ipc_shm_connect(const char *shm_name) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b865db96_0ac48435 PS2, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) { Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36035164_70bc0a8f PS2, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cfe66c3_11aceee0 PS2, Line 339: shmptr = static_cast<IFT *>(ptr); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d00b8d1c_6187717b PS2, Line 339: shmptr = static_cast<IFT *>(ptr); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/71c58734_ccdbefc9 PS2, Line 344: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6affbb4d_01d5a5b8 PS2, Line 348: strncpy((char *)shmname, name, 512); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cfa4a6_a0f6af2f PS2, Line 350: void create() Bad function definition - void create() should probably be void create(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0587c0_3cb673fc PS2, Line 350: void create() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad193449_65ce6949 PS2, Line 355: void open() Bad function definition - void open() should probably be void open(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd360768_d3ef3120 PS2, Line 355: void open() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f64c4e21_7482d277 PS2, Line 360: bool isgood() const Bad function definition - bool isgood() should probably be bool isgood(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5630194f_a38df97d PS2, Line 364: void close() Bad function definition - void close() should probably be void close(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0cf2e12_d08242a4 PS2, Line 364: void close() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2b65f4e_7291a6d2 PS2, Line 369: IFT *p() Bad function definition - IFT *p() should probably be IFT *p(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510): https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3548f8a3_7a1a3521 PS2, Line 369: IFT *p() open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 11:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment