Attention is currently required from: Hoernchen.
237 comments:
File Transceiver52M/device/ipc2/IPCDevice.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 40: protected:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::vector<smpl_buf *> rx_buffers;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::vector<smpl_buf *> rx_buffers;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 48: std::vector<double> tx_gains, rx_gains;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 57: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 67: virtual bool start() override;
Bad function definition - virtual bool start() should probably be virtual bool start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 70: virtual bool stop() override;
Bad function definition - virtual bool stop() should probably be virtual bool stop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 73: enum TxWindowType getWindowType() override
Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 98: TIMESTAMP timestamp = 0xffffffff) override;
Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 116: virtual double fullScaleInputValue() override
Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 122: virtual double fullScaleOutputValue() override
Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 166: virtual bool requiresRadioAlign() override;
Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 180: virtual inline double getSampleRate() override
Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void)
File Transceiver52M/device/ipc2/ipcif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 37: std::atomic<bool> ms_connected;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 37: std::atomic<bool> ms_connected;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 37: std::atomic<bool> ms_connected;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 39: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 40: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 41: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 42: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 43: std::atomic<size_t> len_written_sps; // ->
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 47: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 48: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 50: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 51: std::atomic<size_t> len_written_sps;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 91: std::mutex ul_q_m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 98: void cur_buf_done()
Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 98: void cur_buf_done()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 103: bool is_empty()
Bad function definition - bool is_empty() should probably be bool is_empty(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 103: bool is_empty()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 107: void reset()
Bad function definition - void reset() should probably be void reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 107: void reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 109: for (auto &i : foo)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 113: ulentry &find_free_at_end()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 123: void push_back(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 123: void push_back(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 130: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 131: void add(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 131: void add(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 149: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 159: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 171: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 176: memset((void*)buf, 0, samp2byte(to_pad_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 203: shm::shm<shm_if> m;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 203: shm::shm<shm_if> m;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 203: shm::shm<shm_if> m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 206: ulburstprovider<10> p;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 206: ulburstprovider<10> p;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 249: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 263: shm::mtx_log::print_guard()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 270: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 275: bool create()
Bad function definition - bool create() should probably be bool create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 275: bool create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 281: bool connect()
Bad function definition - bool connect() should probably be bool connect(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 281: bool connect()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 289: bool good()
Bad function definition - bool good() should probably be bool good(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 289: bool good()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 293: bool is_connected()
Bad function definition - bool is_connected() should probably be bool is_connected(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 293: bool is_connected()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 308: memset((void*)outbuf, 0, samp2byte(howmany_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 309: // return;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 316: auto &dl = ptr->dl;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 325: shm::sema_wait_guard g(dl.w, dl.r);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 331: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 338: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 351: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 356: void drive_tx()
Bad function definition - void drive_tx() should probably be void drive_tx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 356: void drive_tx()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 358: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 384: void signal_read_start()
Bad function definition - void signal_read_start() should probably be void signal_read_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 384: void signal_read_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/device/ipc2/shmif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 46: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 50: std::cerr << str();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 73: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 89: void lock()
Bad function definition - void lock() should probably be void lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 89: void lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 94: bool try_lock()
Bad function definition - bool try_lock() should probably be bool try_lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 94: bool try_lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 99: void unlock()
Bad function definition - void unlock() should probably be void unlock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 99: void unlock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 104: pthread_mutex_t *p()
Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 104: pthread_mutex_t *p()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 109: shmmutex &operator=(const shmmutex &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 109: shmmutex &operator=(const shmmutex &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 115: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 130: void wait(shmmutex *lock)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 135: void signal()
Bad function definition - void signal() should probably be void signal(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 135: void signal()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 140: void signal_all()
Bad function definition - void signal_all() should probably be void signal_all(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 140: void signal_all()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 145: shmcond &operator=(const shmcond &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 145: shmcond &operator=(const shmcond &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 149: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 150: shmcond &s;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 152: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 165: signal_guard &operator=(const signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 165: signal_guard &operator=(const signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 169: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 171: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 173: explicit mutex_guard(shmmutex &m) : m(m)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 186: std::atomic<int> value;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 186: std::atomic<int> value;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 186: std::atomic<int> value;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 190: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 198: void wait()
Bad function definition - void wait() should probably be void wait(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 198: void wait()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 202: void wait(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 205: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 210: void wait_and_reset()
Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 210: void wait_and_reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 214: void wait_and_reset(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 217: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 223: void set()
Bad function definition - void set() should probably be void set(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 223: void set()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 227: void set(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 230: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 234: void reset_unsafe()
Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 234: void reset_unsafe()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 238: bool check_unsafe(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 243: sema &operator=(const sema &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 243: sema &operator=(const sema &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 247: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 248: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 250: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 265: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 266: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 268: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 282: template <typename IFT> class shm {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 282: template <typename IFT> class shm {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 287: int ipc_shm_setup(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 315: int ipc_shm_connect(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 339: shmptr = static_cast<IFT *>(ptr);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 344: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 348: strncpy((char *)shmname, name, 512);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 350: void create()
Bad function definition - void create() should probably be void create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 350: void create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 355: void open()
Bad function definition - void open() should probably be void open(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 355: void open()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 360: bool isgood() const
Bad function definition - bool isgood() should probably be bool isgood(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 364: void close()
Bad function definition - void close() should probably be void close(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 364: void close()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 369: IFT *p()
Bad function definition - IFT *p() should probably be IFT *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
Patch Set #2, Line 369: IFT *p()
open brace '{' following function definitions go on the next line
To view, visit change 30414. To unsubscribe, or for help writing mail filters, visit settings.