[M] Change in libosmo-abis[master]: fix use-after-free in ipaccess_bts_keepalive_fsm_alloc() - gerrit-log

5 May 2023

Attention is currently required from: osmith, laforge, fixeria.

pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/32641 )

Change subject: fix use-after-free in ipaccess_bts_keepalive_fsm_alloc()
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
Summary of what this patch does as I finally understood it:

...
  ah ok, you are advancing osmo_fsm_inst_free() by
advancing call to ipaccess_keepalive_fsm_cleanup()
 and then that means when the other struct is freed, the fsm is already properly freed
beforehand, so it doesn't free it implicitly with talloc_free()" 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32641
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic56c4b5b7b24b63104908a0c24f2f645ba4c5c1b
Gerrit-Change-Number: 32641
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 05 May 2023 17:47:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment