Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 4: (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/ccb75a2c_7aceb2db?usp=em… : PS4, Line 40: This class is abstract, you will only use subclasses in practice. This is exactly what `abc.ABC` is for. Not only it allows to declare methods as abstract, it also tells reader that the class is abstract. https://gerrit.osmocom.org/c/pysim/+/39742/comment/019f762a_45736791?usp=em… : PS4, Line 42: Subclasses have to implement the apply_val() classmethods ... and this would have been obvious if you just defined it as follows: ``` @classmethod @abc.abstractmethod def apply_val(...): ''' ... ''' ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 08 Mar 2025 10:38:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No