Attention is currently required from: neels.

fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )

Change subject: [2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi ......................................................................

Patch Set 4:

(2 comments)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39742/comment/ccb75a2c_7aceb2db?usp=ema... : PS4, Line 40: This class is abstract, you will only use subclasses in practice. This is exactly what `abc.ABC` is for. Not only it allows to declare methods as abstract, it also tells reader that the class is abstract.

https://gerrit.osmocom.org/c/pysim/+/39742/comment/019f762a_45736791?usp=ema... : PS4, Line 42: Subclasses have to implement the apply_val() classmethods ... and this would have been obvious if you just defined it as follows:

``` @classmethod @abc.abstractmethod def apply_val(...): ''' ... ''' ```