Attention is currently required from: neels.

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #4, Line 40: This class is abstract, you will only use subclasses in practice.

    This is exactly what `abc.ABC` is for. Not only it allows to declare methods as abstract, it also tells reader that the class is abstract.

  • Patch Set #4, Line 42: Subclasses have to implement the apply_val() classmethods

    ... and this would have been obvious if you just defined it as follows:

    ```
    @classmethod
    @abc.abstractmethod
    def apply_val(...):
        ''' ... '''
    ```

To view, visit change 39742. To unsubscribe, or for help writing mail filters, visit settings.