Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email )

Change subject: server: Use osmo_stream_srv for non-tls read tcp sock ......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcap/+/39343/comment/078b174b_70d212d3?usp... : PS2, Line 9: TLS handling adds a lot of complexity, so TLS sockets are still read : through the previous code paths, and conversion to osmo_stream_srv is : left as a future improvement.

one might even argue that osmo_stream itself should integrate the TLS support at some point, so that […]

I spent some time at the start trying to already integrate the TLS stuff into the new osmo_stream backend, but the fact that I don't know the details about TLS and that the gnutls API is a bit cumbersome to work with (it expects to call a recv() or similar function even if it is implemented by a buffer) made me take the decision to delay it, otherwise I'd end up burning lots of hours with that.

Also because I don't have a osmo-pcap TLS setup to test stuff in first place. I don't even know whether the TLS feature is expected to work, since I even see some TODOs regarding that feature, example in osmo-pcap.git/TODO...