Attention is currently required from: fixeria.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 )

Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/b91a508f_5ab629a6 PS1, Line 500: what is the correct BTS Tx behavior for frame : * gaps in TCH/AFS

I just suggested a possible solution seeing a FIXME comment in your patch. […]

I hear you - I just don't have the needed AMR expertise to implement proper BFI transmission for AMR like I just did for FR/HR/EFR. Given that no other developers are stepping up right this minute to fix the issue for AMR, it looks like we need to leave it as a FIXME, to be revisited by later developers who care about AMR and have the necessary work-queue priority for it. It could even be me at a much later time, if and when I have the time allocation to get into AMR.