Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 ) Change subject: Support forwarding messages with multiple BSCs ...................................................................... Patch Set 1: Code-Review-1 (6 comments) File doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/165a82cc_6ca294e5 PS1, Line 16: sccp-address bsc why is this dropped in this patch? File include/osmocom/bsc_nat/bsc_nat.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/2f1e3067_1e7e3d15 PS1, Line 49: struct conn { subscr_conn? conn seems to generic, too many layers, protocols, levels. See in osmo-bsc: struct gsm_subscriber_connection See in osmo-msc, functions containing "subscr_conn" https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/a8581ec4_feef0e36 PS1, Line 87: void bsc_nat_conn_del(struct conn *conn); subscr_conn_free() File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/e2443211_1786505a PS1, Line 121: llist_for_each_entry(conn, &bsc_nat->conns, list) { for_each_entry_safe https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/858cb335_69d340fc PS1, Line 131: llist_for_each_entry(conn, &bsc_nat->conns, list) { for_each_entry_safe https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476/comment/86085972_1cfe833b PS1, Line 241: llist_for_each_entry(msc, &bsc_nat->mscs, list) { for_each_entry_safe (previous commit) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1556aa665fbb0a97507f98794e74820731fa6935 Gerrit-Change-Number: 27476 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:29:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment