Attention is currently required from: osmith.

Patch set 1:Code-Review -1

View Change

6 comments:

• File doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg:

  • Patch Set #1, Line 16: sccp-address bsc

    why is this dropped in this patch?

• File include/osmocom/bsc_nat/bsc_nat.h:

  • Patch Set #1, Line 49: struct conn {

    subscr_conn? conn seems to generic, too many layers, protocols, levels.

    See in osmo-bsc: struct gsm_subscriber_connection
    See in osmo-msc, functions containing "subscr_conn"

  • Patch Set #1, Line 87: void bsc_nat_conn_del(struct conn *conn);

    subscr_conn_free()

• File src/osmo-bsc-nat/bsc_nat.c:

  • Patch Set #1, Line 121: llist_for_each_entry(conn, &bsc_nat->conns, list) {

    for_each_entry_safe

  • Patch Set #1, Line 131: llist_for_each_entry(conn, &bsc_nat->conns, list) {

    for_each_entry_safe

  • Patch Set #1, Line 241: llist_for_each_entry(msc, &bsc_nat->mscs, list) {

    for_each_entry_safe (previous commit)

To view, visit change 27476. To unsubscribe, or for help writing mail filters, visit settings.