Attention is currently required from: neels, laforge, fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 )

Change subject: logging: add 'logging timezone (localtime|utc)' ......................................................................

Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: Marking with -1 since I'm not the only one thinking set_timezone() should fail if not supported by the system.

File src/core/logging.c:

https://gerrit.osmocom.org/c/libosmocore/+/32043/comment/b9c67540_4a046f59 PS1, Line 874: target->timezone = timezone;

i don't agree. i would not want to duplicate some enum validation code here. […]

How does the caller (the user) know if it is setting a timezone which is not supported by his system? Does he need to go check cryptic support documentation in Narnia?

This *is* the place where the user should get to know that it is trying to set a value which is not going to work properly on the current system.