Attention is currently required from: neels, laforge, fixeria.

Patch set 2:Code-Review -1

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    Marking with -1 since I'm not the only one thinking set_timezone() should fail if not supported by the system.

• File src/core/logging.c:

  • Patch Set #1, Line 874: target->timezone = timezone;

    i don't agree. i would not want to duplicate some enum validation code here. […]

    How does the caller (the user) know if it is setting a timezone which is not supported by his system? Does he need to go check cryptic support documentation in Narnia?

    This *is* the place where the user should get to know that it is trying to set a value which is not going to work properly on the current system.

To view, visit change 32043. To unsubscribe, or for help writing mail filters, visit settings.