Attention is currently required from: laforge, osmith, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35207?usp=email )

Change subject: util: add osmo_strbuf macros to manipulate the strbuf tail ......................................................................

Patch Set 2:

(2 comments)

File include/osmocom/core/utils.h:

https://gerrit.osmocom.org/c/libosmocore/+/35207/comment/0bf789f8_bb1c30ef PS2, Line 288: #define OSMO_STRBUF_CHAR_COUNT(STRBUF) ((STRBUF).buf && (STRBUF).pos > (STRBUF).buf ? \

I would really welcome some extra formatting (lines) and more parenthesis to make this readable at a […]

ack on the parens, the line formatting "ok if you need that"

File src/core/utils.c:

https://gerrit.osmocom.org/c/libosmocore/+/35207/comment/ab90371f_4cbcb308 PS2, Line 1238: if (!sb->pos)

how is it is possible that if n_chars were written to sb->pos, sb->pos is null? This makes no sense […]

added comment to explain