Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32073 ) Change subject: gsm_objclass2mo(): First check if TRX number is valid ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32073/comment/a06b4128_d7d0084a PS2, Line 1622: NM_OC_GPRS_NSVC I am not sure if this really applies to `NM_OC_GPRS_NSVC`. AFAIU, in this case `obj_inst->trx_nr` repurposed to indicate the instance number of NSVC, not TRX number. I suggest to remove this one. https://gerrit.osmocom.org/c/osmo-bts/+/32073/comment/ecd8fcaa_d0d5f844 PS2, Line 1623: obj_inst->trx_nr >= bts->num_trx `gsm_bts_trx_num()` does exactly this check internally, no need to duplicate it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9f21f1a0a9dab897d4fd89ab6b7341ca4aec8b22 Gerrit-Change-Number: 32073 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Mar 2023 00:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment