Attention is currently required from: arehbein.

Patch set 2:Code-Review -1

View Change

2 comments:

• File src/common/oml.c:

  • Patch Set #2, Line 1622: NM_OC_GPRS_NSVC

    I am not sure if this really applies to `NM_OC_GPRS_NSVC`. AFAIU, in this case `obj_inst->trx_nr` repurposed to indicate the instance number of NSVC, not TRX number. I suggest to remove this one.

  • Patch Set #2, Line 1623: obj_inst->trx_nr >= bts->num_trx

    `gsm_bts_trx_num()` does exactly this check internally, no need to duplicate it here.

To view, visit change 32073. To unsubscribe, or for help writing mail filters, visit settings.