Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30961 )

Change subject: layer23: Initial VTY framework to share VTY code between apps ......................................................................

Patch Set 3:

(5 comments)

Patchset:

PS3: Regarding the 'exists', I see now that you're copying this as-is, so not critical. But still would be nice to get this fixed at some point later.

File src/host/layer23/src/common/vty.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/21c6c2a1_d0ac6327 PS3, Line 65: exits exist

https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/146f40bc_bd5ecc03 PS3, Line 111: SHOW_STR "Display available MS entities\n") A help string for optional MS_NAME is missing:

show SHOW_STR ms Display available MS entities [MS_NAME] null

https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/9720d90b_97c8ab73 PS3, Line 122: exits exist

https://gerrit.osmocom.org/c/osmocom-bb/+/30961/comment/8212df22_3031f7b4 PS3, Line 123: VTY_NEWLINE alignment