Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 3: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/42690333_1940fbb5 PS2, Line 13: For each BTS, an SI 10 is gerated with all other neighbor BTS. Done Patchset: PS2: The idea was to wait 3 seconds, which allows the MS to receive the SI5* messages before adding the SI10 (which relates to SI5*). There is not much benefit when sending SI10 earlier. Then I thought that it would be enough time for all the channels to be established in that BSC. There is no way to know at the BSC, if the channels requested from the MSC are complete. I could add an update to the SI10 for every channel that is established after the timer has expired. What do you think? File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/4bc38c72_0183a6f2 PS2, Line 1420: struct gsm_subscriber_connection *conn Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/f600693d_fad587ca PS2, Line 1424: *n_bts, *l_bts Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/cd6e512e_cf268bb5 PS2, Line 1447: 32 Done https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/7352572d_8f0c439c PS2, Line 1459: if (c->lchan->ts->trx->bts->c0->arfcn != arfcn) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 14:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment