Attention is currently required from: fixeria, laforge, pespin.
6 comments:
Commit Message:
Patch Set #2, Line 13: For each BTS, an SI 10 is gerated with all other neighbor BTS.
generated
Done
Patchset:
SI10 is actually not needed for the call establishment, it's needed for quicker cell change. […]
The idea was to wait 3 seconds, which allows the MS to receive the SI5* messages before adding the SI10 (which relates to SI5*). There is not much benefit when sending SI10 earlier. Then I thought that it would be enough time for all the channels to be established in that BSC. There is no way to know at the BSC, if the channels requested from the MSC are complete.
I could add an update to the SI10 for every channel that is established after the timer has expired. What do you think?
File src/osmo-bsc/system_information.c:
Patch Set #2, Line 1420: struct gsm_subscriber_connection *conn
should be `const`
Done
Patch Set #2, Line 1424: *n_bts, *l_bts
cosmetic: better declare these two separately, so they're not hidden behind the `s_bts` assignment. […]
Done
where this limit is coming from? […]
Done
Patch Set #2, Line 1459: if (c->lchan->ts->trx->bts->c0->arfcn != arfcn)
can we maybe have a "i_bts = c->lchan->ts->trx->bts;" var here to avoid dereferencing crazy amounts […]
Done
To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.