Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 5: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a5dd17f5_d153a58d PS5, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c75e4485_212c1a94 PS5, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d67c0539_72bba0dc PS5, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/de26b202_8c562839 PS5, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1618f8e3_c652898f PS5, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/977e63f6_881052e3 PS5, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/266ab51b_84cf7837 PS5, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/03a8713e_083f24df PS5, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c31b7302_94df4c8c PS5, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/bd93e3fe_dda3b5eb PS5, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/bea2e2de_646a4495 PS5, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/663f5f82_d98d66f7 PS5, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/74dd9f87_9f7e275f PS5, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a546a4a7_605fda5f PS5, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9e7647ae_f32531f3 PS5, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e5a5b9ff_4962009c PS5, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f5df8216_d9151cd9 PS5, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/dd9f506f_76aa85dd PS5, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f93fe8ff_eb02a58f PS5, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a484a9e8_2543f66e PS5, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/0f6b3aa3_c0551ad1 PS5, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e2e790e9_49f92066 PS5, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/453e2e68_d8e879a1 PS5, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/965d4086_9aedc3df PS5, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9b3ac1eb_381d55bd PS5, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/19f21466_dbf7ed0f PS5, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/389eb214_0c504952 PS5, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e7e98a04_c720f219 PS5, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/80e654f6_023fd8db PS5, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d4112896_1505b17f PS5, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/6a4495db_40353f81 PS5, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8881eba5_88e0d9fe PS5, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/51d2c8fc_cf4740bd PS5, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/70f040f3_2c7e3267 PS5, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/6d7b8f50_34886f12 PS5, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07727629_e01a7d41 PS5, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f81e5036_785672ee PS5, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/866e17c7_2c2d9b8c PS5, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ed1a632f_6d6169fe PS5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/efd78e01_3c0cd4c0 PS5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d3394eae_d8f289e8 PS5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e2d28ee6_61e08b63 PS5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 5 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Comment-Date: Tue, 17 Jan 2023 19:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment