Attention is currently required from: laforge.
42 comments:
File src/host/layer23/include/osmocom/bb/common/netdev.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 35: unsigned int ihl:4;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 36: unsigned int version:4;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 38: unsigned int version:4;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 39: unsigned int ihl:4;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 43: u_int8_t tos;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 44: u_int16_t tot_len;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 45: u_int16_t id;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 46: u_int16_t frag_off;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 47: u_int8_t ttl;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 48: u_int8_t protocol;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 49: u_int16_t check;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 50: u_int32_t saddr;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 51: u_int32_t daddr;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 57: struct osmo_sockaddr addr;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 58: uint8_t prefixlen;
please, no spaces at the start of a line
File src/host/layer23/src/common/netdev.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 45: #elif defined (__FreeBSD__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 49: #elif defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) {
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 };
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 };
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 };
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2815):
Patch Set #5, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 };
space required after that ',' (ctx:VxV)
To view, visit change 30993. To unsubscribe, or for help writing mail filters, visit settings.