Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (8 comments) Patchset: PS3: Some of my comments were not addressed yet. File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/334133ab_d84069de PS3, Line 959: struct { It probably makes more sense to have this struct declared in the bts_ramp_setup.h and use it here, but not that important. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/42835f41_b088f63b PS3, Line 3089: "Enable BTS setup ramping to limit the number of BTS which configure within a time window.\n" ... the amount of BTS to configure ... https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6e1debe3_d1eb117c PS3, Line 3090: "Limit number of BTS.\n" amount. number may be misleading here since we use the concept of "BTS number" bts_nr. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cd4b56fc_432aede4 PS3, Line 3091: "Number of BTS" missing dot. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3d5d696d_7f22901c PS3, Line 42: /* inform all MOs */ My comment regarding moving this to a generic address was not applied nor got feedback. https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5e03b765_8f21c08f PS3, Line 201: llist_del(&bts->bts_setup_ramp.list); what's the content of &bts->bts_setup_ramp.list after calling llist_del? Because if it's not llist_entry_empty()==true then net time the BTS reconnect you will have problems. File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/12111ba4_be72a166 PS1, Line 345: case NM_EV_RAMP_GO: This has not yet been applied. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Oct 2022 10:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment