Attention is currently required from: lynxis lazus.
8 comments:
Patchset:
Some of my comments were not addressed yet.
File include/osmocom/bsc/gsm_data.h:
Patch Set #3, Line 959: struct {
It probably makes more sense to have this struct declared in the bts_ramp_setup.h and use it here, but not that important.
File src/osmo-bsc/bsc_vty.c:
Patch Set #3, Line 3089: "Enable BTS setup ramping to limit the number of BTS which configure within a time window.\n"
... the amount of BTS to configure ...
Patch Set #3, Line 3090: "Limit number of BTS.\n"
amount.
number may be misleading here since we use the concept of "BTS number" bts_nr.
Patch Set #3, Line 3091: "Number of BTS"
missing dot.
File src/osmo-bsc/bts_setup_ramp.c:
Patch Set #3, Line 42: /* inform all MOs */
My comment regarding moving this to a generic address was not applied nor got feedback.
Patch Set #3, Line 201: llist_del(&bts->bts_setup_ramp.list);
what's the content of &bts->bts_setup_ramp.list after calling llist_del? Because if it's not llist_entry_empty()==true then net time the BTS reconnect you will have problems.
File src/osmo-bsc/nm_bb_transc_fsm.c:
Patch Set #1, Line 345: case NM_EV_RAMP_GO:
Since this only makes sense when in DISABLED_DEPENDENCY or DISABLED_OFFLINE, better move it (duplica […]
This has not yet been applied.
To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.