Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: * mixes two different topics in one patch * please don't remove the name. In some of our intended use cases we have *many* instances of soft-uarts (e.g. a modem bank / RAS server, or a CSD<->modem IWF). * The fact that the code doesn't log anything using the logging framework is a bug (See my other comment regarding fprintf) * even just for state introspection like "show ..." vty commands a name is very useful adding the cfg argument can then be squashed in the original patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e78d60c747a8805064d5e4bacfd47a30bc65cba Gerrit-Change-Number: 35021 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 16 Nov 2023 15:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment