Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email )

Change subject: saip-tool: add features to add and remove applications profile elements ......................................................................

Patch Set 1:

(6 comments)

Patchset:

PS1: In general what we're seeing is that it may probably make sense to eventually (at a later point, unrelated to this patch) switch to something like a 'saip-shell' which has various commands. This way the user could start saip-shell with a UPP in DER format, and then navigate the PEs, update/remove/reorder/whatever and save at the end. Those steps then could also be performed with scripts, like pySim-shell supports.

File contrib/saip-tool.py:

https://gerrit.osmocom.org/c/pysim/+/39860/comment/a7b17e7a_3f22f4b4?usp=ema... : PS1, Line 22: import zipfile removing those unused imports is a logically separate change, isn't it?

https://gerrit.osmocom.org/c/pysim/+/39860/comment/a793ac1c_15e913b6?usp=ema... : PS1, Line 267: app_index = 0 shouldn't we simply make this part of the 'info' command? We already display some basic information about applications there. If you're worried about verbosity, we could add a '--verbose'

https://gerrit.osmocom.org/c/pysim/+/39860/comment/75d235ac_f93364e0?usp=ema... : PS1, Line 272: I think this line should be removed, it's likely just a debug aid?

https://gerrit.osmocom.org/c/pysim/+/39860/comment/ad77b270_2aa23f46?usp=ema... : PS1, Line 349: 0]

I am not sure here, As far as I know there can be multiple securityDomain PEs in a profile. […]

There can be multiple security domains. It's probably unusual, but legal AFAIR. I suggest to check if there's only one and abort if there are multiple printing a message that this is currently not yet supported.

https://gerrit.osmocom.org/c/pysim/+/39860/comment/383cc264_2fd3faf4?usp=ema... : PS1, Line 375:

I wonder if it is better to put this in a method in ProfileElementApplication?

yes, I think a method would be better style.