Attention is currently required from: dexter.
6 comments:
Patchset:
In general what we're seeing is that it may probably make sense to eventually (at a later point, unrelated to this patch) switch to something like a 'saip-shell' which has various commands. This way the user could start saip-shell with a UPP in DER format, and then navigate the PEs, update/remove/reorder/whatever and save at the end. Those steps then could also be performed with scripts, like pySim-shell supports.
File contrib/saip-tool.py:
Patch Set #1, Line 22: import zipfile
removing those unused imports is a logically separate change, isn't it?
Patch Set #1, Line 267: app_index = 0
shouldn't we simply make this part of the 'info' command? We already display some basic information about applications there. If you're worried about verbosity, we could add a '--verbose'
I think this line should be removed, it's likely just a debug aid?
I am not sure here, As far as I know there can be multiple securityDomain PEs in a profile. […]
There can be multiple security domains. It's probably unusual, but legal AFAIR. I suggest to check if there's only one and abort if there are multiple printing a message that this is currently not yet supported.
I wonder if it is better to put this in a method in ProfileElementApplication?
yes, I think a method would be better style.
To view, visit change 39860. To unsubscribe, or for help writing mail filters, visit settings.