Attention is currently required from: iedemam, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28165 ) Change subject: stats: new trackers for lchan life duration (v2) ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: It may make sense to do some profiling how much time it takes to run the whole callback function for all the BTSs, to see if it makes more sense to split the timer per BTS. If it takes a lot of time it may block the osmo-bsc from forwarding stuff. File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/f0986220_0eed4f43 PS1, Line 768: if (!lchan->activate.concluded) I wonder: you are probably then not counting last interval since .concluded was set to true. https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/3884051f_f6fb8022 PS1, Line 772: timespecsub(&now, &lchan->active_stored, &elapsed); what if it's first time? active_stored is {0,0} ? EDIT: I see it's stored in lchan_on_fully_established(). Maybe write a comment about that here. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/b914c556_f60124f4 PS1, Line 574: vty_out(vty, " Activated %s seconds ago%s", "Active for: %d seconds%s" would probably fit more in existing print format. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 20:07:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment