Attention is currently required from: iedemam, neels.
4 comments:
Patchset:
It may make sense to do some profiling how much time it takes to run the whole callback function for all the BTSs, to see if it makes more sense to split the timer per BTS. If it takes a lot of time it may block the osmo-bsc from forwarding stuff.
File src/osmo-bsc/bts.c:
Patch Set #1, Line 768: if (!lchan->activate.concluded)
I wonder: you are probably then not counting last interval since .concluded was set to true.
Patch Set #1, Line 772: timespecsub(&now, &lchan->active_stored, &elapsed);
what if it's first time? active_stored is {0,0} ?
EDIT: I see it's stored in lchan_on_fully_established(). Maybe write a comment about that here.
File src/osmo-bsc/bts_trx_vty.c:
Patch Set #1, Line 574: vty_out(vty, " Activated %s seconds ago%s",
"Active for: %d seconds%s" would probably fit more in existing print format.
To view, visit change 28165. To unsubscribe, or for help writing mail filters, visit settings.