[S] Change in libosmocore[master]: osmo_io: Add possibility to resend a message - gerrit-log

16 Oct 2023


      Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34750?usp=email )
Change subject: osmo_io: Add possibility to resend a message
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/34750/comment/c57dc922_bcf8a4ad 
PS1, Line 86: int osmo_iofd_rewrite_msgb(struct osmo_io_fd *iofd, struct msgb *msg);
I'm not really liking the name of this API, it's confusing. Rewrite message sounds like changing the content of the msgb. The proper name would be "prepend_msgb" probably, or "reenqueue_msgb".
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34750?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9cc588294fcaee49e334282183672aa32fa30bee
Gerrit-Change-Number: 34750
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Comment-Date: Mon, 16 Oct 2023 08:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment