Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32392 ) Change subject: e1d: do not set fd number to 0 after close ...................................................................... Patch Set 1: (1 comment) File src/input/e1d.c: https://gerrit.osmocom.org/c/libosmo-abis/+/32392/comment/1801b110_1d5cc633 PS1, Line 494: if (bfd->fd <= 0) { these checks can most probably be changed to <, and the "> 0" also can be changed to ">= 0"? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I72e4775135caf4e3727c4f0654a545478c73bb83 Gerrit-Change-Number: 32392 Gerrit-PatchSet: 1 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 20 Apr 2023 15:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment