pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email )
Change subject: fake_trx: Allow setting sched RR priority for clckgen thread
......................................................................
Patch Set 3:
(1 comment)
File src/target/trx_toolkit/clck_gen.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/39815/comment/89bc1b3d_65839b44?u… :
PS3, Line 73: self._thread.sched_rr_prio = self.sched_rr_prio
Why is this needed? You're already setting `self.
[…]
Sorry I didn't see your comment before merging.
AFAIU this class is a separate object from the internal thread object which can be
accessed through the _worker()? Or am I wrong? It's been a while since I last wrote
python :)
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc
Gerrit-Change-Number: 39815
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: kirr <kirr(a)nexedi.com>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Mar 2025 19:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>