Attention is currently required from: jolly, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email )
Change subject: LAPDm: Add support for RTS based polling ......................................................................
Patch Set 14:
(1 comment)
File src/gsm/lapdm.c:
https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/398ba832_aea74fb3 PS14, Line 527: * This function must be ca I guess the documentation misses the fact that it must only be called for every FN if we are in F_RTS mode. Also, it might make sense to move the check for F_RTS up here so it only leads to one error messge, instead of one for each atalink within the entity. the static lapdm_t200_fn_dl then could have an additional OSMO_ASSERT() as it's an internal function and the caller should have checked for the RTS flag before.