[S] Change in libosmocore[master]: gsm_04_08_gprs.h: Introduce packed struct gsm48_pdp_address
Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email )
Change subject: gsm_04_08_gprs.h: Introduce packed struct gsm48_pdp_address ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:
https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/96b1bef5_eba53381 PS1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */
Ack
Not addressed, but looks like it's `struct_endianness.py` is forcing this formatting?
https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/97de1324_eac812b9 PS1, Line 340: ietf
Yeah you cannot do that, but I don't see it being a problem. […]
Ack, just mentioning. Not critical.
-
fixeria