Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30971 )
Change subject: layer23: Initialize osmocom_ms further in common code
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/common/ms.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30971/comment/f1b91e4e_48da1be1
PS1, Line 33: ms->name = talloc_strdup(ms, name);
Why do we need separate 'name' field? Why not
use talloc_get_name()?
because one thing is what user establishes in VTY and the
other is the internal talloc name which can show in talloc reports.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30971
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic629cf229167ddd4c533a2abf1b82ad78d1144a9
Gerrit-Change-Number: 30971
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 14 Jan 2023 19:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment