Attention is currently required from: dexter, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email )

Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ......................................................................

Patch Set 8:

(1 comment)

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/2d415c7c_33c76717 PS8, Line 1374: OSMO_ASSERT(!(mgcp_msg->param_present && mgcp_msg->codecs_param_present));

when we add a fmtp string to ptmap, then we don't need a codecs_param list nor a codecs_param_presen […]

hmm, can we assume to control all existing osmo_mgcp_cient users? it would be very tempting to just drop the stupid 'param' completely, because its compatibility code would have to compose fmtp strings again... just thinking, probably not going to happen, right