Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email ) Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 1: (2 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/cfb40d6a_e52d… : PS1, Line 734: /*, { Why was it already commented out here? I think because it's an **optional** IE that requires at least one E-RAB item (i.e. cannot be empty). There needs to be a logic (likely a function) that would be adding this IE conditionally based on the template parameter `rab_failed_items`. For instance, we want to exclude this `protocolIEs` item completely if `istemplatekind(rab_failed_items, "omit")`. Yes, I would like to add such testcase (if the time permits). But for a normal scenario when eNB reports all E-RABs as set up, this IE shall not be present in the list. This is why I am commenting it out below in `tr_S1AP_InitialCtxSetupResp`. For that special scenario with not all E-RABs being set up we can: * go for adding the additional `f_gen_protocolIEs()` logic, * easy to implement for `?` or `omit` * gets really complex for `*` * add another pair of templates extending `{ts,tr}_S1AP_InitialCtxSetupResp` * not if that would work for a list of `protocolIEs` though * add optional IEs conditionally in the testcase itself https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/cdd7908c_be3f… : PS1, Line 755: protocolIEs := { `superset()` removes the need to put the `*` at the end (which was there before my patches). It does not solve the problem of having optional IEs in a template though. I am fine with migrating to `superset()` in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 Gerrit-Change-Number: 38277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 11:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>