Attention is currently required from: jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email )
Change subject: Add logging category for libosmo-cc
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/35572/comment/31874ad6_11a066cc
PS2, Line 158: #defin
this breaks ABI; it means we need to bump the
LIBVERSION on next libosmocore release and hence needs […]
That's why I proposed
adding the category dynamically if it makes sense, because it avoids breaking the ABI.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7
Gerrit-Change-Number: 35572
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 24 Jan 2024 12:36:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment