Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email )

Change subject: mgw: do not fail MGCP on codec mismatch ......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/35302/comment/45061c23_9c6b5db1 PS1, Line 21: Still fail if one side has no codecs -- the only reason is that changing I?m not following here. I don't understand why failing when the other side has no codecs set.

File src/libosmo-mgcp/mgcp_codec.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35302/comment/41f41a41_69ec2572 PS1, Line 478: LOGP(DLMGCP, LOGL_ERROR, "no matching codec found\n"); you definetly want to print the endpoint or conns here.